Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148631542
@karuturi sure, it was a normal, standard installation via the web UI on
CentOS6 HVs and mgmt, no automation.
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148689735
Code LGTM. I couldn't test but did a check in the source and found the
recurring pattern for this was applied in several cases. It should not have
been applied
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148703718
Run the following tests:
```
Test router internal advanced zone ... === TestName:
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148684942
I ran BVT tests on a setup with two xenserver 6.5. I didnt see any new
failures.
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148696476
Thanks @DaanHoogland and @NuxRo . I will merge this in sometime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148724604
So,
1. we did not test enough
2. we have an issue that sneaked into master
3. you have a test env issue
I don't like
---
If your project is
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/934
[4.6][BLOCKER] CLOUDSTACK-8923: Create storage network IP range failed
This is a regression from commit 0cd8c06f7dceaf999acf202862c5d1d580e7aa0e
try-with-resource used at
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148346807
@NuxRo Can you test this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148597263
@NuxRo for the benefit of the next reviewer, can you please outline the
manual/automatic tests you executed?
---
If your project is set up for it, you can reply
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/934#issuecomment-148469676
@karuturi Tested, it works! Thanks!
I'm happy with this so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
11 matches
Mail list logo
