Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/878
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/878#issuecomment-142606607
@borisroman True, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/878#issuecomment-142605044
Listing vm's by user_id will work as assumed; for projects the vm will be
listed by the user who created it.
---
If your project is set up for it, you can reply
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/878#issuecomment-142604837
Seems good to me. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/878#issuecomment-142601843
This looks good, but does this have an impact elsewhere? Did you test
listing vms by user_id?
---
If your project is set up for it, you can reply to this email and ha
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/878
[4.6][BLOCKER]CLOUDSTACK-8890: Added isEmpty() check to prevent
nullPointerException.
Check if the list is empty before trying to get the first entry. If the
list is empty, in example when d
