[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161557568 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161549425 @remibergsma @borisroman Please, be aware that there is a change in the ```tools/marvin/marvin/lib/common.py``` file. It means that you have to

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161557066 The test passes fine here, also on a 2 node cluster: test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... ===

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161595328 @remibergsma time to merge! It also got a LGTM from @DaanHoogland :) Cheers, Wilder --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161428530 @wilderrodrigues Will start some tests! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161434770 Ping @DaanHoogland @remibergsma @borisroman @bhaisaab More tests! * Tests executed ``` nosetests --with-marvin

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161484253 given the number of tests done I am fine with this. I also reviewed the code, lgtm, I am not confident to put it in capitals but am floating on my experience

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161528070 Ping @remibergsma @DaanHoogland @borisroman Before testing, please note that the smoke/test_privategw_acl.py now requires hardware! *

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1151 [4.6] CLOUDSTACK-9075 - As a Developer I want the Private GW feature fixed on single VPCs This PR fixes the issue we faced with Private Gateways on single VPC when using ACS 4.6.0 and

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161274671 Ping @remibergsma @DaanHoogland @borisroman You can start testing now... just a matter of running the following: ``` cd

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161290470 Ping @remibergsma @DaanHoogland @borisroman Since I touched the router code, I also executed the rVPC tests to make sure those are working fine! I

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9075 - As a Developer I ...

2015-12-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1151#issuecomment-161291156 Jenkins error is related to this: ![image](https://cloud.githubusercontent.com/assets/5129209/11532121/fa1f7274-9901-11e5-8e80-23c199c96a71.png)