Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161430026
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161429404
@ustcweizhou Took me a while, but the issue is not in this PR. Will post
test results soon.
---
If your project is set up for it, you can reply to this email a
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161337904
Okay... no panic! I might have been some expunge global settings that is
deployed on all of our test environments. It has been reverted and I will run
the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161310807
Ping @remibergsma @DaanHoogland @ustcweizhou @bhaisaab
The test fails on latest 4.6 branch!
```
=== TestName: test_01_stop_vm | Status
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161272059
Thanks, @bhaisaab!
I will test it and and also see if I have time tomorrow to run the same
tests agains this PR. We need to be 100% sure that it wor
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161270573
@wilderrodrigues I'm approaching EOD today, but can help test master
tomorrow.
I tested vm lifecycle manually with 4.6.1 RC1 and KVM, so I suppose 4.6
should b
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161266056
@remibergsma @DaanHoogland @wido @bhaisaab @ustcweizhou @karuturi @runseb
@borisroman @jburwell
If test_vm_life_cycle.py is failing because the cu
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161250671
test/integration/component/test_browse_volumes.py
this test might be impacted.
---
If your project is set up for it, you can reply to this email and have y
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161249455
@remibergsma @wilderrodrigues checked the code (java and
test_vm_life_cycle.py), I think this PR is not related to the failure in
integration test. Can you plea
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161243997
@wilderrodrigues I just tested.
I set the storage.cleanup.interval to 60s, the storage.cleanup.delay to
120s.
I restored a VM, then the old v
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161224861
@wilderrodrigues no, just code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-161223389
@ustcweizhou @bhaisaab @wido
Did you actually test this PR?
Cheers,
Wilder
---
If your project is set up for it, you can reply to thi
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160989059
@remibergsma any update ?
@wido yes, #1029 for master, and #1044 is a mistake
---
If your project is set up for it, you can reply to this email and have you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160928383
The integration tests show this test failing (part of
test_vm_life_cycle.py):
```
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160922052
@wido cool, it's one of the those that seemed like bugs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160915928
LGTM based on the code. Seems sane to me.
@bhaisaab This seems like a feature, so I don't think it's supposed to go
into 4.5?
---
If your project is set up f
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160906723
+1 LGTM (had reviewed before)
@ustcweizhou If we merge it on 4.6 and fwd-merge on master, we won't need
the PR #1029. Lastly, do you think we should put this in
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160904404
@wido yes https://github.com/apache/cloudstack/pull/1144 , just PR against
correct branch now
---
If your project is set up for it, you can reply to this email and h
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1145#issuecomment-160903564
I would swear I saw this code before. Dejavu moment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1144#issuecomment-160758013
@pdube @remibergsma I will recreate a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ustcweizhou closed the pull request at:
https://github.com/apache/cloudstack/pull/1144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1144#issuecomment-160756847
@ustcweizhou This is a mistake I guess, PR against the wrong branch?
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1144#issuecomment-160739865
Hey @ustcweizhou, could you create the PR towards 4.6 please, it is hard to
determine exactly what you changed. Thanks
---
If your project is set up for it, you can
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1145
[4.6.1] CLOUDSTACK-9022: keep Destroyed volumes for sometime
for now, the Destroyed volumes will be expunged in Storage cleanup thread,
no matter when they are destroyed.
In Expunging v
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1144
[4.6.1] CLOUDSTACK-9022: keep Destroyed volumes for sometime
for now, the Destroyed volumes will be expunged in Storage cleanup thread,
no matter when they are destroyed.
In Expunging v
26 matches
Mail list logo
