Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-216200365
@ustcweizhou please squash changes into one, rebase against master and push
-f, and update on status of your PR, thanks
This looks like a interesting feature
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192958023
@kiwiflyer Simon, Thanks for your bug report, I will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928225
---
If your project is set up for
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928190
---
If your project is set up for
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928201
---
If your project is set up for it,
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928078
We've tested this patch against master. Snapshots work correctly and data
is displayed in UI when using supported storage backend (NFS), so nice work!
We
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-180465442
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-175675613
@ustcweizhou please rebase against latest and send for a re-review
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162565931
Run the tests again. LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162334352
@wido any reason we shouldn't merge this in before 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162234338
Yes we do, it might not be the final solution as per the discussion above
but it is an improvement.
---
If your project is set up for it, you can reply to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162232240
@ustcweizhou Can you please rebase and resolve the conflict? I can then run
the tests again.
@wido @DaanHoogland Do we want this in 4.7?
---
If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-158615300
Hi @wido can you review this again please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-157883615
reran the tests. I noticed time out on destroy ssvm en cpvm but all others
succeed. These timeouts, I have seen before in unrelated PRs. the systemvms
come up
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-153650536
@wido code are updated.
I have a node running with Ubuntu 12.04/qemu 1.2.1/libvirt 0.9.13 (not
stock QEMU 1.0 and libvirt 0.9.8). It works fine in the vm
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-153371179
My bad, there is no libvirt-java upgrade possible at this point. I was
mistaking libvirt 1.1.0 for a possibility.
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-153369869
@DaanHoogland I meant the version of libvirt running on the HV which is out
of our control.
I still vote for no longer supporting Ubuntu 12.04 for that reason
17 matches
Mail list logo
