Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-222134718
This one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-222134484
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 16m 13s
```
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-221631305
@syed can you review this error? It seems to be related to your test.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-221631046
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 1
Duration: 4h 14m 49s
```
**Summary of the
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-220739003
@syed please close and reopen or repush. we are close to freeze and I want
to get some of these PRs in...
---
If your project is set up for it, you can reply to
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-217990022
Thanks @syed. I will get CI run against this. I see we have the required
code review, so I just need to get CI run. Thx...
---
If your project is set up for it,
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-217972968
@swill Sqashed. I believe this is good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-216224619
LGTM
@syed can you do a rebase and push -f again thanks
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-212062046
@syed looks like marvin plugin is missing; if you've both python 2.6/2.7
(looks like nose is using python 2.6) make sure to install it for the one you
use (the
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211996541
@bhaisaab Do you have an idea of why Marvin is failing on my dev setup?
I've followed the guide mentioned
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211537431
Ok, thanks @bhaisaab. So I need to get on the systemvm template stuff asap
to try to get those PRs in a good place so we have a little breathing room
before the RC
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211524917
@swill we can ask around on ML, afaik in addition to strongswan I known of
the ospf stuff by @abhinandanprateek which needs zebra and related packages for
ospf.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211502237
@bhaisaab Ok thanks. Are there other things we want to get into the
systemvm template if we do publish a new one? Probably not the best place for
this discussion,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211481666
@swill we'll need to publish a new systemvm template (i.e. we can no longer
use the 4.6 systemvm template)
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211375246
Introducing an external dependency is probably going to cause some
problems. @bhaisaab can you review this and maybe give some feedback on the
best way to handle
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211374488
@swill I have added a marvin test to see if the VPN service starts
correctly however I am having trouble getting marvin to work correctly. When I
run the test I get
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207917699
thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207898283
@swill I beleieve we can do a better test. After the VPN is set up we can
do something like
`ike-scan -M 172.16.21.200` to see if the VPN opened up. I'll test
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207553542
@syed I have not looked into this. Is it possible for us to improve the
test so it actually tests that the VPN works?
---
If your project is set up for it, you can
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-196448014
@remibergsma Going through the VPN tests on Marvin, I see that it is not
actually testing if VPN is working. It just check if we can enable VPN without
any errors but
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-196429053
@remibergsma I beleive there is a [marvin
test](https://github.com/apache/cloudstack/blob/master/test/integration/smoke/test_vpc_vpn.py)
for this but I beleive it was
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-195547692
If there's a Marvin integration test for this feature, I'm wondering why it
succeeded without this fix. I think we might need to improve the test and show
it's
Github user disappear89 commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-195384632
This should be brought out quickly to community via 4.8.1 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-194962876
@kiwiflyer : Rebase done. Here is the log from the VR when I enable client
side vpn
```
2016-03-10 17:01:25,876 merge.py load:60 Loading data bag type
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-193864782
@syed Can you squash the 2 commits please?
Can you provide some logs showing the fix works?
---
If your project is set up for it, you can reply to this email
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-192893991
This looks like a sensible fix to me. Code LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
42 matches
Mail list logo
