Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/508
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158450166
@pdube
you are right.
system/root admin can access every entity, but root admin cannot create a
vm using other account' affinity groups.
Affinit
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158434572
@ustcweizhou Thanks for the response. I understand the code. I was
wondering why there was a need for a special access checker for AffinityGroups.
After more investig
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158342455
@pdube
you may notice this code in UserVmManagerImpl.java
_accountMgr.checkAccess(caller, null, true, owner, ag);
normally it will check
(1)
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158200709
@ustcweizhou Is that actually necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158200813
Why is that access control done differently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158164720
@pdube
try this change:
```
diff --git a/server/src/com/cloud/acl/AffinityGroupAccessChecker.java
b/server/src/com/cloud/acl/AffinityGroupA
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158075714
@ustcweizhou I am working on it now, but have a few questions about
resource ownership
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158006677
@pdube If you are almost done, I will wait for your PR. Otherwise, I can
work on porting it.
---
If your project is set up for it, you can reply to this email a
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157874321
@ustcweizhou Also if you have a fix for it, why not port it forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157854104
@ustcweizhou I have checked it out into another branch. I am working on it.
And will create a PR when I am done.
---
If your project is set up for it, you can reply
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157853386
@pdube you can create a pull request on github when you finish the coding
and testing.
This PR have lots of issues, so it will not be merged of course.
I
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157754858
Hey @wilderrodrigues @resmo,
I was looking to fixing this as well. Is there any way I can contribute?
What is the status of this?
Thanks,
pdube
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-127280785
@wilderrodrigues ok. thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-127275589
I will start on it this week, hopefully! Just keep the PR open, I will get
it and create a PR on top of your with the tests. In this way we keep track of
eve
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-127274573
@wilderrodrigues did you take it over? can I close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121931545
@wilderrodrigues as long as you don't squash them and keep the attribution
intact, i'm fine with that. otherwise you can also make pull requests to
resmo's fork
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121931572
@wilderrodrigues yes, please. Feel free.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121921520
Hi @resmo
Can I then get your changes, from your PR, work on it and push via another
PR? Would that be okay with you?
If so, I think we cou
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121914103
Hi @wilderrodrigues that would be awesome!
It is not supposed to break backward compatibility. In my opinion the
functionality is implemented and should work,
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121849880
Hi @resmo and @bhaisaab
I will check with @remibergsma / @DaanHoogland / @snuf if that's something
we could get involved in. I'm okay with helping,
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121846292
hey @bhaisaab, still WIP. I ask for some help to finish it on the ML,
because I will not have time to work on it the next months.
---
If your project is set up for it
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121829695
ping, any update on this? still WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/508
[WIP] CLOUDSTACK-6276: project support in affinitygroups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack
feature/6276-projec
24 matches
Mail list logo
