[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/824 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/824#issuecomment-140659167 @DaanHoogland I think that will work; and also the stubs would allow 4.5.3 users to upgrade to 4.6.0 provided there is no schema changes between 4.5.2 and 4.6.0 (wh

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/824#issuecomment-140650501 provided we release 4.5.3 before 4.6.0; LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39593369 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498765 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498419 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498281 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39498235 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade453to460.java --- @@ -30,12 +30,12 @@ import com.cloud.utils.exception.CloudRuntimeException

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39497595 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -120,149 +121,151 @@ public DatabaseUpgradeChecker() {

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/824#discussion_r39497551 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade453to460.java --- @@ -30,12 +30,12 @@ import com.cloud.utils.exception.CloudRuntimeExcep

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/824#issuecomment-140307070 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/824 4.5.3 upgradepath for master branch cc @remibergsma @karuturi You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.5.3-up