[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-162030722 Merging now, that we've enough LGTMs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46698656 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more con

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46694480 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more cont

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161987586 LGTM by code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46687151 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more con

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46686423 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more cont

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46685020 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more contributo

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161929234 once merged on master, I'll rebase quota-master branch (the quota PR) with latest master and then fix it's db upgrade paths. --- If your project is set up for it,

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161929046 LGTM, thanks @DaanHoogland for fixing this so fast --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

2015-12-04 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1173 4.6.0 upgrade path is to pass 4.6.1 to create the extra view in there test build done only You can merge this pull request into a Git repository by running: $ git pull https://github.