Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-205981012
Sure @swill . I've sqashed them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-205926253
@syed can you squash the commits. This is best applied as a single commit.
Thx.
---
If your project is set up for it, you can reply to this email and have your
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-205922970
@bvbharatk it looks to be a problem with the test. Volume creation should
work irrespective of my changes.
---
If your project is set up for it, you can reply to
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-201084616
_Link to logs Folder (search by build_no):_
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
### ACS CI BVT Run
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-179502412
Can we get this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-176825081
LGTM Tested with a XenServer host and Swift as secondary storage. Got the
link and downloaded the template
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-176289614
Added unit tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51153892
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51153916
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51153907
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51154027
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-176629568
With the tests this looks good to me. I have no way of verifying the Swift
working itself, but based on the code and tests: LGTM
---
If your project is set up for
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-175824353
Looks good at first, but I would like to see some UnitTests around methods.
I'll comment on those inline.
---
If your project is set up for it, you can reply to this
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040863
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040885
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040823
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040901
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r50451895
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r50452491
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path) {
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-173688390
JIRA:
[CLOUDSTACK-9248](https://issues.apache.org/jira/browse/CLOUDSTACK-9248)
Tested this on our local setup. Created a template and generated the
download
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r50451763
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-171277602
looks good @syed Can you add test data/description
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606475
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606982
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path)
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606572
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49605888
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1332
Add ability to download templates in Swift
This PR adds the ability to download templates when using Swift as a
secondary storage. Uses the "temp_url" feature of Swift so that tempates can be
28 matches
Mail list logo
