[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1122#issuecomment-161362360 ``` === TestName: test_24_public_IP_tag | Status : SUCCESS === Cleanup resources used ``` LGTM --- If your project is set up for it,

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1122#issuecomment-161260733 thanks, i'll retest after lunch and merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

Re: [GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread Sanjeev N
@daanhoogland I have updated the validation steps. On Wed, Dec 2, 2015 at 2:46 PM, DaanHoogland wrote: > Github user DaanHoogland commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/1122#discussion_r46391214 > > --- Diff: test/integration/component/test

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1122#discussion_r46391214 --- Diff: test/integration/component/test_tags.py --- @@ -2401,3 +2403,143 @@ def test_23_list_untagged_host_for_vm_migration(self):

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1122#issuecomment-161225032 Thanks for writing this test, @sanju1010. It's much appreciated! @remibergsma and you executed the test and I went through the code. So, it LGTM :+1

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-11-30 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1122#issuecomment-160711475 LGTM, the test runs fine here: ``` Testcreation, adding and removing tag on public IP address ... === TestName: test_24_public_IP_tag | Status : SUC

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-11-29 Thread sanju1010
Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1122#discussion_r46107622 --- Diff: test/integration/component/test_tags.py --- @@ -2401,3 +2403,143 @@ def test_23_list_untagged_host_for_vm_migration(self): i

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-11-29 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1122#discussion_r46095649 --- Diff: test/integration/component/test_tags.py --- @@ -2401,3 +2403,143 @@ def test_23_list_untagged_host_for_vm_migration(self):

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-11-25 Thread sanju1010
GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/1122 Add marvin test to verify if DomainAdmin is able to delete the tags on public ip address Please go through bug https://issues.apache.org/jira/browse/CLOUDSTACK-9084 for more details.