Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/679
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130612388
@wido @remibergsma @koushik-das Folowed up on lastest comments by Remi and
Koushik.
---
If your project is set up for it, you can reply to this email and have yo
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130602430
@borisroman I have provided a code comment. Once you fix that and squash
the commits as suggested by @remibergsma then its a LGTM from me. Thanks for
the unit te
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/679#discussion_r36958780
--- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java
---
@@ -125,6 +130,16 @@ public SecurityGroupResponse
newSecurityGroupResp
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130600502
@borisroman Could you please squash the commits into 1 (or maybe 2 if you
want the tests separate).
---
If your project is set up for it, you can reply to this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130564758
LGTM if you fix the brackets in the if-statement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/679#discussion_r36946797
--- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java
---
@@ -125,6 +130,15 @@ public SecurityGroupResponse
newSecurityGroupResponse(Se
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130313964
@koushik-das Added tests. Please have a look!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130231279
@wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes
related to https://github.com/apache/cloudstack/pull/593.
---
If your project is set u
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130175830
Please add tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/679#discussion_r36827811
--- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java
---
@@ -125,6 +130,14 @@ public SecurityGroupResponse
newSecurityGroupResp
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/679
Added Virtualmachine count and ID's to listSecurityGroups response
See issue CLOUDSTACK-8133 for more information.
You can merge this pull request into a Git repository by running:
$ git
12 matches
Mail list logo
