Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127855771
@jayapalu
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127534445
Removed convert_sec_to_h() on esp_policy.
@wilderrodrigues Please review this commit also
---
If your project is set up for it, you can reply to this email and
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127503187
Thanks, @jayapalu
In order to give a LGTM, I checked the way it was used with the
ipsectunnel.sh script. Indeed, it should be esp_policy instead of
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127497586
@wilderrodrigues Can you please review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/655
Added missed esp policy
esp is added with esp_lifetime instead of esp_policy, corrected it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/
