Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-113106273
Pull request branch has been updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-113102919
@ProjectMoon can you rebase and re-submit the PR, the travis tests seems to
be failing.
---
If your project is set up for it, you can reply to this email and have
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-111496943
Yes, that is correct it would need to be done during build time. I can add
a way to make the list of files configurable. I think it would be best to make
a prope
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-111481710
@ProjectMoon my concern here is -- you're still making changes in the XML
to make it work during build time, is there a way to make it configurable like
rabbitmq pl
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-111475122
This would be a step-by-step way of how I tested the change. We will use
mycommands.properties as the example.
1. Add the new properties file name to the list
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-111468655
@ProjectMoon can you share any test results? Is the spring xml gets into
the compiled jar from users' perspective, how may I configure a different
properties file,
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-109915316
Is there anything I can do to assist with the testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-108627999
LGTM, though we need to test it by producing packages. In theory, the
/etc/cloudstack/management should be on classpath so this should work.
---
If your project is
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/354#issuecomment-108552449
Looks like the Oracle VM3 build failed in the pul request check. Is that a
problem on the master branch currently?
---
If your project is set up for it, you can
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/354
Allow custom command role ACL files on classpath in Static Role API Checker
## Commit Message
This commit has a small refactoring of cloud-plugin-acl-static-role-based
to allow it to
11 matches
Mail list logo
