[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218649198 Thanks gents. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218600092 LGTM. We tested this in our Lab on HW and all static routes on each PG came up as expected. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218597071 @rafaelweingartner yes, it will be forward merged. Sorry I only just got around to answering your question. I need one more code review on this one. Thanks... --

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243 LGTM. Tested in a hardware lab. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218577635 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 06m 23s ``` **Summary of the p

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-217552585 So, Si (@kiwiflyer) and I have been testing this functionality against VPCs in our lab and we verified that static routes are indeed loaded when a VR goes from BACKU

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1472#discussion_r62331395 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsStaticRoutes.py --- @@ -0,0 +1,42 @@ +#!/usr/bin/python +# -- coding: utf-8 -- +

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-217289669 We'll be pulling this one in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-216227202 tag:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-208652206 Does the “CsHelper.execute” logs the commands being executed and their outputs? If not, what about adding logs to show the routes that are being ad

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-208578340 Can I get some code reviews on this PR? I have added it to my CI queue... --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: Apply static routes on change to master s...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1472 Apply static routes on change to master state Refactored static routes for private gateways so they also get loaded when the router switches to master state. Otherwise they're lost and conn

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Apply static routes on change to master s...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1468 Apply static routes on change to master state Refactored static routes for private gateways so they also get loaded when the router switches to master state. Otherwise they're lost and conn