Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-123562895
@sudhansu7 can you please rebase the changes for master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-122262701
@karuturi @kishankavala can you answer @bhaisaab or add your LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r34755962
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -124,6 +127,9 @@
description = "true
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-118248786
There is an API change. Should this go into master only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r33769718
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -215,33 +221,39 @@ public long getEntityOwnerId() {
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-118006807
@karuturi
When a user switches to project view the ownership changes to project
account. So any resource created inside project view should be mapped to
proje
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-117978565
@sudhansu7 can you reply to @karuturi ? thanks. Otherwise this will stay
stuck waiting for your answer.
---
If your project is set up for it, you can reply to this e
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r31692655
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -215,33 +221,39 @@ public long getEntityOwnerId() {
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-108717787
Do we really need projectId here? The api doc says "A template created
from this command is automatically designated as a private template visible to
the account t
GitHub user sudhansu7 opened a pull request:
https://github.com/apache/cloudstack/pull/334
BUG-ID: CLOUDSTACK-8483 - Private template not visible in project
added new 'projectId' parameter in createTemplate command and based current
user, account and projectid decide the owner of t
11 matches
Mail list logo
