Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-118706569
Awesome @sudhansu7. Congratulations on the first marvin test :+1: :)
I will push this to master in sometime.
---
If your project is set up for it, you can repl
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-118331438
@remibergsma @karuturi
I have added marvin test for this issue.
Test result from local setup:
Sudhansus-MAC:cloudstack sudhansu$ nosetests --with-m
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-118020313
@sudhansu7 Let's first merge this to master, then it can go to 4.5. I just
tried to merge your PR on master and that seems to work just fine so that is
nice.
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-118007318
@remibergsma @runseb
This issue exists in 4.5 , hence fixed it in 4.5. this can me merged to
master as well.
---
If your project is set up for it, you can r
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-117978306
@sudhansu7 there is a question here from @remibergsma , can you answer it
so it can get merged.
---
If your project is set up for it, you can reply to this email and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-117951281
Code looks good, although I didn't test it yet. Before I do, I'd like to
understand why do you want to push this to 4.5 and not to master?
---
If your project i
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-111468788
LGTM, I guess unit tests would be cool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-108718604
Can you add some unit/marvin tests?
Also, fix the commit msg header to 72 :)
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
---
If your
GitHub user sudhansu7 opened a pull request:
https://github.com/apache/cloudstack/pull/335
BUG-ID: CLOUDSTACK-8484 - Hosts without tag are not listed while listâ¦
â¦ing the hosts for migration for instance with tag
While preparing the suitable hosts we are accidentally rem
10 matches
Mail list logo
