Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-213686569
Thanks Swill and now All the checks are passed.Please merge this PR.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-212906931
I think this one is ready. I want Jenkins to be green before I merge
though. I will review what is going on with Jenkins today. I will this to my
merge list.
---
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-212820627
LGTM based on the code review!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-208331373
HI,
Thanks for your review comment and i ran the few tests on the created
setup even though it won't impact the any testcases but for your request i ra
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-206460206
I don't have the ability to test this. Would you mind running the
following tests to verify there are no issues in the setup once the DC has been
deployed and then p
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-206273934
LGTM based on code walk through
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-206272202
I have incorporated the all the review comments and squashed all my
commits to single commit.
This script prepares setup required to run advanced ba
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-204588967
Shouldn't the path shown in line 55 of your config file be OS-independent?
I'd also suggest fixing the typo in the file name. At least I believe it
was mean
Github user cloudsadhu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1458#discussion_r58188259
--- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg ---
@@ -0,0 +1,191 @@
+{
+"zones": [
+{
+"name
Github user cloudsadhu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1458#discussion_r58188294
--- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg ---
@@ -0,0 +1,191 @@
+{
+"zones": [
+{
+"name
Github user cloudsadhu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1458#discussion_r58188213
--- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg ---
@@ -0,0 +1,191 @@
+{
+"zones": [
+{
+"name
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1458#discussion_r58182115
--- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg ---
@@ -0,0 +1,191 @@
+{
+"zones": [
+{
+"name":
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1458#discussion_r58181661
--- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg ---
@@ -0,0 +1,191 @@
+{
+"zones": [
+{
+"name":
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1458#discussion_r58180544
--- Diff: tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg ---
@@ -0,0 +1,191 @@
+{
+"zones": [
+{
+"name":
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-204301035
tools/marvin/marvin/config/Baremtal_AdvZone_Vmware.cfg does not have a
license. @cloudsadhu please add it.
---
If your project is set up for it, you can reply
GitHub user cloudsadhu opened a pull request:
https://github.com/apache/cloudstack/pull/1458
BUG-ID:CLOUDSTACK-9331:added code in marvin frame&new config file for
advBaremetal support â¦
Added code in marvin framework&new config file to support baremetal
advanced testcases
You
17 matches
Mail list logo
