[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-12-06 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-162353745 @DaanHoogland PR #1124 rebased on top of master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-12-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-162345306 @rafaelweingartner you better read #1177, part of #1124 will no longer merge cleanly because of the ovm3 changes. --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-12-06 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-162339992 Actually, the one that obsoleted this is #1124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-12-06 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1056 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-12-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-162339708 #1177 obsoleted this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-15917 @rafaelweingartner please go ahead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-159128519 @DaanHoogland, would you like me to finish the changes that we need, so we can proceed with this PR? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-156434822 @rafaelweingartner too late :cry: is running, next spin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-156434491 Before you run the Xen tests, I think you should apply the changes in "XenServerGuru.java" and remove the method "EndPoint selectHypervisorHost(Scope scop

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-156430873 did the sbp regression tests on this: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false \ smoke/t

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155887354 see INFRA-10703 at the apache jira :) and cast your vote for it --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-11 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155882720 Cool, It seems that the JVM crashed during Jenkins execution. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CID-1338387: remove logicless execution c...

2015-11-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155861504 running the regression tests on this but these are not in ovm(yet) will look into that. --- If your project is set up for it, you can reply to this email and