[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

2015-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/822 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

2015-10-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/822#issuecomment-150839334 Hi @DaanHoogland LGTM, based on a set of tests that I run on this branch: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advance

[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

2015-10-19 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/822#issuecomment-149162159 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CID 1324349: conditionally return -1 or t...

2015-09-14 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/822 CID 1324349: conditionally return -1 or the dc id for the volume You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstac