Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-175677195
LGTM
Merging based on 2+LGTMs, test results shared in comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-162476357
regression tests executed:
[1044.network.results.txt](https://github.com/apache/cloudstack/files/53778/1044.network.results.txt)
[1044.vpc.results.txt]
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155751828
Ah, right, checking the code is important. :-D
I'll go back to my corner.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155748424
@NuxRo @ustcweizhou is using "cloudst...@apache.org$" for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155740283
Good point as well with the "unexpected". I definitely see where Wei is
coming from, but I think it could be misleading. Perhaps a better way to do
this is mark the A
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155737852
@NuxRo valid point but isn't this unexpected behavior instead of expected?
The key was not added by the UI (or API) but will be removed by it. If we need
this
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155735899
On a second thought - and something worth pondering on - this could have
some security implications.
Imagine you have a private cloud, a developer/employee le
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155734540
@ustcweizhou
How did you test it?
I think we should stick to a LGTM being given only if tests have been done
and steps, on how to test, ha
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-155003768
Looks good, sane commit.
I agree with @NuxRo that cloud-init is imho the way forward. We probably
want to ditch these legacy scripts at some point.
---
If yo
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-154707648
Makes sense and looks good, but I am surprised you are still using these
scripts instead of cloud-init.
On the same note, worth having a look at how cloud-init beh
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-154691168
makes sense and looks good. @ustcweizhou I assume you have tested this in
production already, no?
---
If your project is set up for it, you can reply to this
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1044
CLOUDSTACK-5822: keep user-added sshkeys in authorized_keys
For now, if we add the ssh key inside the vm (not on cloudstack UI), the
sshkey will be removed if we reset the sshkey on cloudst
13 matches
Mail list logo
