Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-176046154
cc @remibergsma requires merging on 4.6 and consequent fwd merges
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-175894714
add (GB) to the label. Please test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-175691303
@ustcweizhou please add the "GB" label after the string, then we can merge
this. Thanks.
---
If your project is set up for it, you can reply to this email and hav
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-175691008
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1342#discussion_r50058625
--- Diff: ui/scripts/ui-custom/instanceWizard.js ---
@@ -429,12 +427,52 @@
$step.find('.custom-size-label').remove
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-172243612
LGTM, the UI shows fine and the value is passed to the API as shown in
screenshot. See comment above, please add "GB" after the field.
https://cloud.git
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-172241961
@ustcweizhou @DaanHoogland Will test this soon. Can you please add that the
size that one needs to specify is in GB? Didn't look so I had to look that up
;-)
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1342#issuecomment-172188453
LGTM based on code and function- manual test (see screen print)
 Revert commit 13bf1ec5da9891eca98ef5dab61bf74b6db9530b to show t
11 matches
Mail list logo
