Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/68#issuecomment-71788178
Yes. It seems travis CI errored out before running any tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/68#issuecomment-71204924
Comment, should we merge it? TravisCI is complaining?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/68#issuecomment-70241529
Yes it will always be null for migration entries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/68#issuecomment-70241318
Let me rephrase - are you certain that the extract url (download url) of
the volume that needs migration will be always null? Consider possible schema
changes. I was
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/68#issuecomment-70239302
If not download_url than there needs to be other entry in db to detect the
difference type of entries. But that will require the DB change and will not
achieve any
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/68#issuecomment-70238401
@anshul1886 Good workaround, though relying on null state is probably not a
good idea? Is there a way you can detect that without using null-ness but a
state associat
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/68
CLOUDSTACK-6900: This fixes volume migration failing after that volume is
downloaded
When we download volume then we create entry in volume_store_ref table.
We mark the volume entry to rea
