Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20492616
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20492860
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/41
CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for
global settings which are of type integer and float
Do not allow to set invalid values for global settings which are
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20488370
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20488404
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/41#issuecomment-63430386
Can you add unittests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20489652
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20489860
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String
