[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69900395 Tested with CloudMonkey/Marvin, most sane clients should not break who search for objects in a "xyzresponse" key. This also fixes the UI so we're good. Google

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-13 Thread nitmehta
Github user nitmehta commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69821830 Does this break backward compatibility ? How is this string used ? Can you please post the old and new response for this ? --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-13 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69767205 I am +1 with this, looks like a typo. definitely good for master. maybe other bug fix releases. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69761669 Since, this is an API related change I'm hesitant to merge into master without a discussion around this on dev ML. Can you start a thread on dev ML to discuss fixing

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69761365 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-13 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/63 CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's' Signed-off-by: René Moser You can merge this pull request into a Git repository by running: $ git pull https://github