GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/116
CLOUDSTACK-8323: Adding test case to verify NIC Adapter types for nic in VM
when NIC Adapter is specified in template
The test case will verify that when a template is registered with
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/116#issuecomment-78451371
@gauravaradhye looks good, any results/outputs? Sorry not a test guru to
help review/merge it.
---
If your project is set up for it, you can reply to this email
Yes ran the test case on master. It succeeded. Although it is skipped for
now because it needs VCenter integration. It will be easy to enable this
test in future once it is available.
Log:
Add network to running VM ... === TestName: test_vm_nic_adapter_vmxnet3 |
Status : SUCCESS ===
ok
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/116#issuecomment-78461087
@gauravaradhye patch fails to apply on latest master, please rebase and
send a mergeable patch
---
If your project is set up for it, you can reply to this email
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/116#issuecomment-78474569
Thanks @gauravaradhye merged on master now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Rebased, please try now.
Regards,
Gaurav
On Thu, Mar 12, 2015 at 4:41 PM, bhaisaab g...@git.apache.org wrote:
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/116#issuecomment-78461087
@gauravaradhye patch fails to apply on latest
