[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

2015-07-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/583#issuecomment-121606896 LGTM from Abhi (on chat); test setup on http://acs.bhaisaab.org:8080/client/ --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

2015-07-14 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/583#issuecomment-121236324 LGTM :+1: Also talked to @bhaisaab on Slack about the 2 accountsWizard.js just to get some context. Cheers, Wilder --- If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

2015-07-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/583#issuecomment-121153413 cc @abhinandanprateek @wilderrodrigues @jburwell and others --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

2015-07-14 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/583 CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form This uses local selector to access the DOM elements, the previous commit would find a global element which is not in the context and