[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/268 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-06-01 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/268#issuecomment-107824833 This looks good and all review comments have been incorporated. Merging this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-06-01 Thread abhinavroy02
Github user abhinavroy02 commented on the pull request: https://github.com/apache/cloudstack/pull/268#issuecomment-107824748 Attaching test execution logs This Test Path tests vMotion for NFS as well as VMFS within cluster, ... === TestName: test_01_vm_and_volumes_live_migra

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-06-01 Thread abhinavroy02
Github user abhinavroy02 commented on the pull request: https://github.com/apache/cloudstack/pull/268#issuecomment-107814688 @gauravaradhye Incorporated the review comments. Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-05-21 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/268#issuecomment-104535446 Posting review here as I am not able to put inline review comments. Comments in the format (line number space comment) 133 space between self,v

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-05-20 Thread abhinavroy02
Github user abhinavroy02 commented on the pull request: https://github.com/apache/cloudstack/pull/268#issuecomment-103851151 Hi Gaurav, Even I am not getting that option. Is it because it is a new file or something? Thanks, Abhinav On May 20, 2015 16:54, "G

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-05-20 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/268#issuecomment-103848262 Don't know why I can't comment on the testpath file. I don't see the file contents in the changes. Any idea why? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-05-20 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/268#discussion_r30691290 --- Diff: tools/marvin/marvin/lib/base.py --- @@ -2520,6 +2520,35 @@ def reconnect(cls, apiclient, **kwargs): [setattr(cmd, k, v) for k,

[GitHub] cloudstack pull request: CLOUDSTACK-8487 : Add vMotion related tes...

2015-05-20 Thread abhinavroy02
GitHub user abhinavroy02 opened a pull request: https://github.com/apache/cloudstack/pull/268 CLOUDSTACK-8487 : Add vMotion related tests Adding a new test script testpath_vMotion_vmware.py in the test/integration/testpath folder. This script has vMotion related test cases for