This code is a bug. To split in two conditions range 1 is a /31 or range 1
is not a /31;
precondition: endIp1Long == startIp1Long + 1
1: startIp2Long - startIp1Long == startIp2Long - (endIp1Long -
ip31bitPrefixOffSet)# - startip2Long
2: - startIp1Long == - (endIp1Long - ip31bitPrefixOffSet)
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/292#discussion_r30943691
--- Diff: utils/src/com/cloud/utils/net/NetUtils.java ---
@@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress
address) {
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/292#discussion_r30943403
--- Diff: utils/src/com/cloud/utils/net/NetUtils.java ---
@@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress
address) {
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/292#issuecomment-104872293
Ah, indeed.
There is the logic you mentioned in the previous comment and 1 added call
to NetUtils.isIpWithtInCidrRange() line 1509 which is:
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/292#issuecomment-104871936
the pr contains a lot of added final keywords, more then actual code.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/292#issuecomment-104871245
@DaanHoogland , I also commented on your comments.
Which bit is hard to review? Put a lot of test results and also did the
manual tests for the publi
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/292#discussion_r30943304
--- Diff: utils/src/com/cloud/utils/net/NetUtils.java ---
@@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress
address) {
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/292#discussion_r30943291
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3556,6 +3556,11 @@ private void checkPublicIpRangeErrors(long z
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/292#issuecomment-104865612
hard to review this, @wilderrodrigues I made one comment on the logic.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/292#discussion_r30943140
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3556,6 +3556,11 @@ private void checkPublicIpRangeErrors(long zone
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/292#discussion_r30943135
--- Diff: utils/src/com/cloud/utils/net/NetUtils.java ---
@@ -329,35 +329,46 @@ public static String getMacAddress(InetAddress
address) {
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/292
CLOUDSTACK-8506 - Make ACS compliant with the RFC 3021
Hi @bhaisaab and @DaanHoogland
Could you please have a look at this PR and also at the RFC 3021?
It allows us to h
13 matches
Mail list logo
