Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/582#issuecomment-122029800
LGTM :+1:
Can I merge it, @wido, or would you like to do it?
Cheers,
Wilder
---
If your project is set up for it, you can reply to thi
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34786110
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) {
return false;
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34755599
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) {
return false
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34674108
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) {
return false
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/582#issuecomment-121226423
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
you can add that commit here for my part, please don't squash it;)
On Tue, Jul 14, 2015 at 12:30 PM, wido wrote:
> Github user wido commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/582#discussion_r34554904
>
> --- Diff:
> plugins/storage/image/s3/src
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34554904
--- Diff:
plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
---
@@ -60,7 +60,9 @@ public DataStoreTO g
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/582#issuecomment-121191099
logic looks good with respect to the functional description. could do with
tests
---
If your project is set up for it, you can reply to this email and have you
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34553635
--- Diff:
plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
---
@@ -60,7 +60,9 @@ public DataS
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/582
CLOUDSTACK-8581: S3, make connection TTL and TCP KeepAlive configureable
Signed-off-by: Wido den Hollander
You can merge this pull request into a Git repository by running:
$ git pull https:/
11 matches
Mail list logo
