[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-12-14 Thread kishankavala
Github user kishankavala closed the pull request at: https://github.com/apache/cloudstack/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-09-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-142064215 @kishankavala There are 5 merge commits now... please remove them. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-09-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-139304798 @kishankavala Please remove the 4 merge commits, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-134923368 maybe rebase and fix any issues, to get Travis green before merging this once @wido can review this. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-134923025 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-08-19 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132647888 @kishankavala Thanks for the update! When you're ready, also be sure to ping @wido so he can have another look. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-08-17 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132073238 @remibergsma I've update the PR. There is still one issue open regarding the usage of /tmp --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-08-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-131209754 @kishankavala Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-07-17 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122219752 @wido @bhaisaab Made the suggested changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-07-17 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122247318 Code-wise I'm not to happy. There are all kinds of assumptions about paths. mkisofs for example always being there in /usr/bin. Using /tmp for temporary

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-07-15 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/577#discussion_r34755687 --- Diff: packaging/centos63/cloud.spec --- @@ -129,6 +129,8 @@ Requires: perl Requires: libvirt-python Requires: qemu-img Requires:

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

2015-07-10 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/577 CLOUDSTACK-8605: KVM: Config Drive and getVmIp support - CLOUDSTACK-8324 added support for External DHCP/DNS support along with ConfigDrive for XenServer - FS link: