Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-134925991
LGTM, merging. Someone needs to add the unit test, later. I'm trying to
build my skills around vmware related codebase.
---
If your project is set up for it, you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-129227018
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-125155019
+1 for @DaanHoogland's comments: please add unit tests to cover the changes.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-124869104
please add (unit) tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-124468346
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-124474599
Looks like all checks are good and there are 2 LGTM too.
Should we merge this branch?
---
If your project is set up for it, you can reply to this
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/554#issuecomment-122200420
LGTM.
Device id 7 on virtual SCSI (can be of any sub type : LsiLogic, LsiSAS,
BusLogic, Paravirtual) controller is reserved for controller itself,
GitHub user likitha opened a pull request:
https://github.com/apache/cloudstack/pull/554
CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 â¦
â¦instance.
During disk attach, while trying to obtain the controller key for SCSI
controller, look for device
