[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-121138730 Manually closing PR. I did a rebase to do away with unnecessary merge commit. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-121133952 Although RAT build status is showing ABORTED, the report is clean. Also the build failed due to some random test failure. Since travis is green, I am going ahead

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120906494 test logic makes sense; LGTM waiting for travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120903118 @karuturi @DaanHoogland Added unit tests for CPVM allocation. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120476327 I would like to see tests with such a change as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120456206 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-09 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120227544 Can you add some unit tests or marvin tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-09 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120222980 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-09 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/571 CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its… … initial start-up process If SSVM cannot be started then the existing entry is removed and a new SSVM get