[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/813 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140650649 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-15 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140303120 @bhaisaab Could you take a quick peek? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140185766 LGTM - tested again with the new changes and the package build succeeds and the packages install fine on CentOS 7. Also tested start/stop/status and rebooted the

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139913812 @remibergsma I did and made another small change. I don't have a very good CentOS dev setup here, so I wasn't able to test it very thorough. I think this should

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139907185 @wido In order to get it to work on CentOS 7 I had to patch it like this. You may want to add it to the PR: ``` diff --git a/packaging/centos7/cloud.

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139897498 Hey @wido.. question: I tried building the packages: `./package.sh -d centos7` Got this error: ``` Processing files: cloudstack-agent-4.6.0-SN

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139873749 @wido Cool, thank you! Will test tomorrow :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/813 CLOUDSTACK-8625: Systemd profile for CloudStack Agent With CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using system