GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/598
CLOUDSTACK-8642: SSO Method not allowed bug fix.
Due to CLOUDSTACK-8505 and commit 1c81b241e7914b24b06c3b7b3ee98bc0d3b4f68b
only POST methods are allowed. This needs to be explicitly stated
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121951761
LGTM
Seems like a use-case which was missed when this was changed
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121956704
makes sense, do we have a unit test mech on javascript code?
LGTM
---
If your project is set up for it, you can reply to this email and have your
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121967055
LGTM.
who will merge it? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/598#issuecomment-121981261
I should, mine was the second 'LGTM' but was hoping for some discussion on
javascript test code
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
