Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/695#issuecomment-131748203
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/695
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/695#issuecomment-131794896
Thanks for merging @remibergsma :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/695#issuecomment-131816390
@karuturi I'm trying to keep an eye on the PRs and merge those that meet
the requirements to keep the list as short as possible :-)
---
If your project is set
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37157665
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java ---
@@ -375,6 +377,18 @@ public void uploadFile(String urlString, File
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37135193
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -52,7 +52,7 @@ public static boolean isUtf8Supported() {
return
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/695
CLOUDSTACK-8669: create volume failed due to null charset
Added a new private method getCharSetFromConnection() which checks if
the connection charset is null and if it is null, returns
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37114980
--- Diff:
vmware-base/test/com/cloud/hypervisor/vmware/util/VmwareContextTest.java ---
@@ -0,0 +1,46 @@
+package
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37115023
--- Diff:
vmware-base/test/com/cloud/hypervisor/vmware/util/VmwareContextTest.java ---
@@ -0,0 +1,46 @@
+package
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/695#issuecomment-131229881
I have a relative lot of remarks for this bit. please take them as a
compliment.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37115247
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java ---
@@ -375,6 +377,18 @@ public void uploadFile(String urlString, File
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37115172
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -52,7 +52,7 @@ public static boolean isUtf8Supported() {
return
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37133216
--- Diff:
vmware-base/test/com/cloud/hypervisor/vmware/util/VmwareContextTest.java ---
@@ -0,0 +1,46 @@
+package com.cloud.hypervisor.vmware.util;
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37133264
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -52,7 +52,7 @@ public static boolean isUtf8Supported() {
return
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/695#issuecomment-131086429
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
15 matches
Mail list logo
