Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127569273
Reviewed the code. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/651
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127292168
The failing check is a Travis timeout. Seems not related, is it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36102628
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36102819
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127312399
@borisroman @remibergsma the timeout is not related to anything but travis
and maybe to the way we use it
---
If your project is set up for it, you can reply
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/651
CLOUDSTACK-8703: Fixed issue when listing directory on S3.
It would only return objectSummaries when the anwser from the S3 System was
truncated.
You can merge this pull request into a Git
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127375332
@DaanHoogland If it fits, its OK. Usually when people do this, it doesn't
fit any more and GitHub will cut it. If the issue id is in the body, you can
still
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127376598
@remibergsma I will look at this with @borisroman tomorrow at the office. I
want to verify his logic. Code seems good for now.
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127360713
thanks for the comments Boris LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127366917
I cannot test the functionality myself right now, although it looks OK.
@wido can you verify and give a final LGTM? I'll then merge it.
@borisroman my
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/651#issuecomment-127368979
@remibergsma Are you sure you don't want the issue ref on the first line?
CLOUDSTACK-8703: Fixed issue when listing directory on S3
It would
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36103980
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final String
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36103914
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final String
14 matches
Mail list logo
