[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

2015-08-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131756869 LGTM. one note of worry though. removing the configuration item is arguably a backwards incompatible change to the interface. I don't object to it, as stated

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

2015-08-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131761320 Thanks for picking this up @koushik-das LGTM @DaanHoogland I see your point, but the alternative is a setting that does nothing. I think that is worse.

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

2015-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

2015-08-17 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/701 CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persisten… …t VR configuration changes Removed out-of-band VR reboot code Refer to the discussion on dev

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

2015-08-17 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131741834 @remibergsma @DaanHoogland Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your