Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/735#discussion_r37953111
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
---
@@ -286,7 +287,11 @@ private void
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/735#issuecomment-134890826
renamed the method,
s/deleteExitingLinkLocalRouteTable/deleteExistingLinkLocalRouteTable/g
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/735
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/735#issuecomment-134591140
While it is a small nit and not expressly within the scope of this PR,
could you fix the spelling mistake in the ``deleteExitingLinkLocalRouteTable``
name?
---
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134595147
See comments on PR #735 regarding extracting the parsing logic and unit
testing.
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/735#discussion_r37865908
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
---
@@ -286,7 +287,11 @@ private void
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/735#issuecomment-134329574
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/733
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
Based on @jburwell's comment on PR #718
You can merge this pull request into a Git repository by running:
$ git pull
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134158150
@bhaisaab Can you send this PR against master please? For now, I'd rather
merge to master, then cherry-pick back to 4.5 as I want to prevent all the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134160459
@remibergsma merges cleanly on master, if you LGTM; I can merge this on
master and 4.5
---
If your project is set up for it, you can reply to this email and have
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134160495
@remibergsma sending another PR just for master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/735
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
Based on @jburwell's comment on PR #718
You can merge this pull request into a Git repository by running:
$ git pull
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134161439
@remibergsma here: https://github.com/apache/cloudstack/pull/735
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134164753
@bhaisaab Thanks, now the tests can run on master as well :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134164828
LGTM on this one, will do the other once the tests are done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/733#issuecomment-134364934
@jburwell can you review this please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/735#issuecomment-134364893
@jburwell can you review this please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
18 matches
Mail list logo
