GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/745
CLOUDSTACK-8773 : NPE in CheckRouterTask, when a DomainRouter happensâ¦
⦠to be expunged at the same time
You can merge this pull request into a Git repository by running:
$ git pull
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/745#discussion_r37960337
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -251,8 +251,11 @@ public boolean remove(final Long id) {
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/745#issuecomment-134914138
@karuturi I've used the method you suggested, this problem occurs in a
specific scenario which is hard to reproduce in a consistent way.
---
If your project is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/745#issuecomment-134910642
LGTM, you can also use the method @karuturi has suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/745#issuecomment-134916577
@nlivens thanks for the update. :+1:
will merge in sometime once travis completes. I assigned you
CLOUDSTACK-8773. please resolve it once this is merged.
---
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/744
CLOUDSTACK-8773 : NPE in CheckRouterTask, when a DomainRouter happensâ¦
⦠to be expunged at the same time
You can merge this pull request into a Git repository by running:
$ git pull
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/745#issuecomment-134906322
A unittest to verify this case would be nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
