Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/788#discussion_r39034047
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -610,20 +608,22 @@ protected HypervisorType
getClusterToStartDomainRou
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138889015
Will proceed with the merge.
Thanks, guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138887396
My issue is also gone, so LGTM from me as well. Thanks for fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138887313
@koushik-das They have been different for a long time. I think when VPC was
invented, they reordered the nics so that the tiers came last (because you can
have N
On 09 Sep 2015, at 12:14, koushik-das
mailto:g...@git.apache.org>> wrote:
One more doubt. Why the ordering of interfaces are different in regular VR and
VPC VR? Has it changed recently or was like this since the beginning? And will
it cause more issues down the line when VR or VPC VR scripts a
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138865017
One more doubt. Why the ordering of interfaces are different in regular VR
and VPC VR? Has it changed recently or was like this since the beginning? And
will it
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138861606
Other than one minor comment, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/788#discussion_r39025559
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -610,20 +608,22 @@ protected HypervisorType
getClusterToStartDomainRouterF
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138851642
I've tested the patch as well since I was hitting the exact same issue. All
is working fine, and interfaces are configured correctly. :+1:
---
If your project is se
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138846797
I tested the patch, now isolated network VR is coming up and the interfaces
are configured in correct order.
eth0 - guest
eth1 - link local
eth2
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138594852
Tests results:
Test advanced zone virtual router ... === TestName:
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Ma
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/788
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nics
Hi there,
I refactored the configureDefaultNics() method in order to split the
implementations f
13 matches
Mail list logo
