Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-212753295
@pdion891 This wasn't tested with HVM VMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user simongodard commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-212573040
I confirm what @pdion891 described in the previous comment.
http://markmail.org/thread/4nmyra6aofxtu3o2
---
If your project is set up for it, you can reply
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-212423092
@koushik-das does this fix got tested with HVM vm having more than 4 VDI?
because we are experiencing issue where an HVM vm on XenServer 6.5 having 4 vdi
(1 root
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/792
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-142236155
Merging as 2 LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/792#discussion_r39962919
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3407,6 +3390,18 @@ public void ha
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/792#discussion_r39839158
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3407,6 +3390,18 @@ public void h
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/792#discussion_r39827592
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3407,6 +3390,18 @@ public void ha
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-140359521
one remark, lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/792#discussion_r39499607
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3407,6 +3390,18 @@ public void h
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-140317652
Can anyone review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-139524545
code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-138819369
I had to undo changes from PR https://github.com/apache/cloudstack/pull/773
to run the tests.
---
If your project is set up for it, you can reply to this email
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/792
CLOUDSTACK-8826: XenServer - Use device id passed as part of attach vâ¦
â¦olume API properly
If device id passed as part of API and available then use it otherwise
fallback on XS
14 matches
Mail list logo
