Github user maneesha-p commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53932297
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String d
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53255088
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private S
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53253724
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String de
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53049082
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private S
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/798#issuecomment-184798743
@maneesha-p can you fix the PR title and its description?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53048362
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String de
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53047922
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String de
Github user maneesha-p commented on the pull request:
https://github.com/apache/cloudstack/pull/798#issuecomment-179159429
@alexandrelimassantana Updated the javadoc. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/798#issuecomment-178042092
Hi @maneesha-p I see you did the extraction, but could you also write the
method javadoc along with it? As simple as it is, it can help people understan
Github user maneesha-p commented on the pull request:
https://github.com/apache/cloudstack/pull/798#issuecomment-177814501
@alexandrelimassantana Updated plz check.Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/798#issuecomment-171739474
@maneesha-p you could extract the content of this if-condition into a
method to test the TaskInfo object, making the code a little more reusable and
al
GitHub user maneesha-p opened a pull request:
https://github.com/apache/cloudstack/pull/798
CLOUDSTACK-8830 CLONE - VM snapshot fails for 12 min after instance â¦
â¦creation Summary: Change in API behavior in vCenter 6.0.0. The name for
VM Power On task is null on VMware vCenter 6
12 matches
Mail list logo
