Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140650784
@bhaisaab I would say unit-tests are necessary to any software project this
big, and with this many independent contributions. You putting the issue of
askin
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140649852
Forgive me for my double negative in, "Be assured that I won't :-1: on
this.", I did mean to say that I won't stop others merging it, as @bhaisaab
explained. I
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140624485
I think Daan did not say -1 or :-1: while unit tests are welcome, does not
hurt to be merciful on one or few line changes if they indeed fix a bug
---
If your proj
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140420588
@wilderrodrigues -> @DaanHoogland Didn't -1, he actually said the opposite.
The screenshots where added to provide context (question from daan). I tested
them to
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140403283
@remibergsma indeed. Perhaps I have been through many untested PRs today
and one more just got my brain in a fuzzy state.
My argument remains as the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140400310
@wilderrodrigues Not sure if @DaanHoogland actually :-1: it, he said he
wouldn't do that. It's confusing though ;-)
---
If your project is set up for it, you ca
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140395721
We got a :-1: from @DaanHoogland and still the PR was merged without any
explanation from the author.
Was it tested by anyone?
ping @bhais
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/804
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-140329820
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-139968967
Attached the screenshots to ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-139533946
the ticket (CLOUDSTACK-8834) mentions a screenshot, which is not there. the
explanation give reproduction hints but is not completely clear because of
this. The
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/804#issuecomment-139521497
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/804
CLOUDSTACK-8834: Fixed unable to download Template , when in multi zones
We were listing image stores by zone id which was resulting in listing of
only one image store
If in that image st
13 matches
Mail list logo
