Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/812#issuecomment-140658229
I agree with @rafaelweingartner that this can have (and deserves) a unit
test maybe it can even be generalized to dynamically find nic prefixes or at
least have
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/812#issuecomment-140650851
LGTM, given the if conditions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/812#issuecomment-139914691
Why donât you extract the content of line 1164 (the condition) to a
method, this way it is possible to create a test case and enables some java
doc. More
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/812#issuecomment-139914467
Looking at the if-statement I give it a LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/812#issuecomment-139874783
@giraffeforestg Thanks for picking this up! Will test it tomorrow.
FYI: You can always make changes after the PR is opened. If you'd want to
change somet
GitHub user giraffeforestg opened a pull request:
https://github.com/apache/cloudstack/pull/812
CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/giraffeforestg
