[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-05-17 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-219637824 @rhtyd >please rebase against latest master and push -f. Done. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-216189486 @priyankparihar please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-25 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-214208033 @priyankparihar Are you saying that you have tested the fix in all scenarios with different HVs (XS, KVM, Vmware)? Also if HV doesn't allow certain operations

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-24 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-214146326 @koushik-das Currently UI does not allow migration between different versions, and changing UI for this change is not elegant. Purpose of doing this

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-21 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212846127 @sateesh-chodapuneedi @koushik-das I will get back to you soon. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-21 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212845624 >Purpose of doing this change is if some user intentionally want to do migration from lower to higher then he can do it via API(from UI he can not do

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-21 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212842765 >>Currently UI does not allow migration between different versions, and changing UI for this change is not elegant. @priyankparihar Why allow

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212832800 @priyankparihar This version check removal is at a generic place and impact all HVs. Since you have only verified for XS 6.2 -> 6.5, there are concerns as to

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-21 Thread rajesh-battala
Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212777172 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-10 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-163542539 @DaanHoogland I did this change because UI does not allow migration between different versions of hyper-visors of but sometimes user wants to do migration

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-162455918 Does what it says but probably more. Do we not mind any other version? @priyankparihar can you show how ACS doesn't allow invalid migrations, "Storage

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-162346266 Pinging @DaanHoogland to review. Will run some tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-140650617 LGTM cc @abhinandanprateek --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-09-14 Thread priyankparihar
GitHub user priyankparihar opened a pull request: https://github.com/apache/cloudstack/pull/815 CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS 6.5 fails. Removed Host version check in API. Because Case 1:(Lower to Higher Version) Storage XenMotion from lower version