Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-86696
### ACS CI BVT Run
**Sumarry:**
Build Number 69
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-218976339
tag:needsreview
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-218869828
Can I get some code review on this? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-216306144
I am missing code reviews on this one...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-216212068
@anshul1886 please rebase against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-203152685
### ACS CI BVT Run
**Sumarry:**
Build Number 145
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=1
Skipped=4
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-171172466
@GabrielBrascher That block of code is in synchronised block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-170268129
@anshul1886 could you please create a method (with documentation) for those
duplicate blocks in ConsoleProxy ( "if(viewer != null &&
!(viewer.getClientHostP
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1269
CLOUDSTACK-8867: Added retry logic to reconnect to host on connection
termination to console
It also improves handling of sessions to hypervisor in console proxy
https://issues.apac
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/835#issuecomment-166514436
Opening new PR with better handling of sessions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/835
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/835#issuecomment-141004854
I agree with @DaanHoogland That should be unit tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/835#discussion_r39599783
--- Diff:
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
---
@@ -115,7 +115,7 @@ public void setLocale(String
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/835
CLOUDSTACK-8867: Added retry logic to reconnect to host on connection
termination
Also changed viewer/console identifier to vm uuid + vnc port to avoid
using same connection console if
14 matches
Mail list logo
