[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-144322464 @pavanb018 it always helps other folks reviewing to know what you did. For example. Did you just check the Travis green light ? Did you just check the code

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142820449 @remibergsma Next time sure I will add some details .for this PR i have updated my comments . --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142819336 An LGTM is given after going through the code and understanding what the code is accomplishing. The PR already has the test results and if i am not wrong an LGTM

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142696052 @pavanb018 @nitt10prashant Could you please add what you tested next time? A LGTM without any explanation doesn't really tell me anything to be honest. --- If

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

@pavanb018 good catch !! It is not part of the code but will change. On Wed, Sep 23, 2015 at 10:52 AM, pavanb018 wrote: > Github user pavanb018 commented on the pull request: > > https://github.com/apache/cloudstack/pull/871#issuecomment-142497091 > > @Desc: Test

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/871 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142493294 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142497091 @Desc: Test that Volume snapshot for root volume not allowed ... === TestName: test_01_test_vm_volume_snapshot | Status : SUCCESS === ok Sanju1010 ,

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/871 CLOUDSTACK-8893: Fixing script as per the latest functionality Please check https://issues.apache.org/jira/browse/CLOUDSTACK-8893 for more details. You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/871#issuecomment-142271544 @Desc: Test that Volume snapshot for root volume not allowed ... === TestName: test_01_test_vm_volume_snapshot | Status : SUCCESS === ok