Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153693746
Ping @remibergsma @karuturi @borisroman @DaanHoogland @miguelaferreira
Test is finally done and bug-free!
Test Environment:
*
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153701619
Jenkins error is not related. It says "no failures" but still shows a red
button on Cloud Server. By the way, I pushed a python file.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153707458
A ticket is out for this at infra: INFRA-10703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153699912
@wilderrodrigues @remibergsma Still had the tests setup running. Here are
the results:
```
=== TestName:
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153717404
Ping @borisroman @remibergsma @DaanHoogland @miguelaferreira @karuturi
Test results:
```
Test redundant router internals ... ===
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153694220
@wilderrodrigues Running now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153726658
LGTM, the test from this branch now succeed:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153701940
JVM died:
https://builds.apache.org/job/cloudstack-pull-analysis/1150/org.apache.cloudstack$cloud-server/console
---
If your project is set up for it, you
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153713989
@borisroman , could you please retest? It worked for me and for you, but
not for @remibergsma due to a resolving thing on RVR test. I then ran it again
and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153656222
Talked with @karuturi and agreed that we make the tests in this PR work,
then merge it. The other issue should be tracked and fixed separately as it is
not a
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153671338
I created https://issues.apache.org/jira/browse/CLOUDSTACK-9027 to track
the new issue
---
If your project is set up for it, you can reply to this email and have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153673995
Thanks, @karuturi !
I already found the error in the test, running it now and will push the
code. The problem was:
* For RVR networks, an
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153681147
Glad you found it @wilderrodrigues and thanks for the fix! Will retest soon!
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153286583
@wilderrodrigues Thanks for the fix, tests are running.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153301644
@wilderrodrigues apart from the issue mentioned in CLOUDSTACK-9018, I found
the below issue.
The egress rule added in a default egress ALLOW network doesnt
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153285784
Ping @remibergsma @borisroman
Partial results (tests still running)
```
Test start/stop of router after addition of one guest network
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153305656
Thanks for the details, @karuturi ! I will fix that.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153309653
More test results. It did not break existing functionality, but still I
will fix the one @karuturi found.
Cheers,
Wilder
```
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153596954
Hi @karuturi,
Sorry, perhaps too earlier here, but I don't follow completely. :)
How did you setup your environment in order to test the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153613824
Thanks a lot, @karuturi !
I reproduce it and once fix write a new test to cover the fix.
Cheers,
WIlder
---
If your project is set up
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153605360
I upgraded an existing xenserver setup with the changes in this PR. (clear
the tags on xenserver and restarted the networks to recreated VRs with new
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153376651
The last test failed because the connection timed out without printing
"Giving up.", as I expected in the test. You can see the output below:
```
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153371614
@wilderrodrigues my bubble is very busy but ping if you are ready and need
testing
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153373615
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153363457
Ping @remibergsma @karuturi @DaanHoogland @borisroman
It's working already, but I'm modifying the tests. I pushed by mistake. If
you want to start
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153370030
Ping @remibergsma @karuturi @borisroman @DaanHoogland
The test is ready! It now does the following:
1. Creates network + VM + FW + PF +
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153372412
Thanks @wilderrodrigues I will test this tomorrow morning IST
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153274765
did the following to test it on an existing XenServer setup (It has two
networks egress_allow with default egress allow and isolated2 with default
egress DENY):
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1023
CLOUDSTACK-8925 - Default allow for Egress rules is not being configured
properly in VR iptables rules
This PR fixes the router default policy for egress. When the default is
DENY,
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1023#issuecomment-153257739
Ping @DaanHoogland @borisroman @remibergsma @miguelaferreira @wido
@karuturi
There is another issue about the VR/egress, but since that's a
31 matches
Mail list logo
