Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157782057
@DaanHoogland those warnings are in files that don't belong to my pull
request.
I could see in
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157748781
@nvazquez can you please look at
http://jenkins.buildacloud.org/job/build-master-slowbuild/2660/findbugsResult/new/
I think these are trivial, you just have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157805785
sorry, @nlivens can you have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/935
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157701917
According to Jenkins the build was fine:
```
Maven: -B -f
/home/jenkins/jenkins-slave/workspace/cloudstack-pull-analysis/pom.xml
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157700801
@nvazquez Can you look at this build failure:
http://jenkins.buildacloud.org/job/build-master-noredist/4746/console
Does the slave need the 5.5 jar or
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157736873
Ok, shouldn't it be removed from the install script and then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157727789
@nvazquez I tried to mv and copy the jar in the job but it doesn't work.
now trying to see if your link yields a newer version then our job has
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157729881
@nvazquez is the older one still needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157718592
@remibergsma It looks like it is not finding 5.5 jar. These are the steps I
followed:
* Download VMware-vSphere-SDK-5.5.0-1284541.zip file from
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157727519
@DaanHoogland Hi! No, just renaming the old jar (version 5.1) will fail
because it doesn't contain opaque network classes. Those ones are introduced in
the 5.5
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157739765
@DaanHoogland Ok, sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157724852
@nvazquez Do you mean to say that we can just rename the old jar to contain
the new version in the name and the sun shines again?
---
If your project is set
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157731551
@DaanHoogland No, it's not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157321576
Couple of minor things that can go through now and be fixed after this is
merged. @miguelaferreira has already tested the PR and showed that it works
just
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r45038824
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/nicira/ControlClusterStatus.java
---
@@ -84,4 +89,17 @@ public int
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157311867
Would be great to include this in 4.7, please ping me when you're ready!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r45038549
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2076,6 +2087,9 @@ private static void
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157154339
@miguelaferreira Great, I rebased my branch to master and pushed again
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-156985757
@nvazquez last Friday 4.6.0 was released so current master is now 4.7.0.
Could you please rebase your branch on latest master?
Then @wilderrodrigues
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-155396401
@nvazquez I've built and tested your PR in our environment and the
functionality we have tests for remains stable. :+1:
What I did:
1.
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-155418071
@wilderrodrigues Thanks a lot Wilder!
@miguelaferreira Thanks for following this PR and testing it!
---
If your project is set up for it, you can reply to
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-152197682
@nvazquez I havent' forgotten your PR. I'm having some trouble with the
automation to re-create a NSX cluster with a KVM host in our test environment.
As
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-151511065
btw, I'm testing your PR in our setup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-151509780
Awesome to see the changes, @nvazquez ! Thanks for being openminded and
also for your contributions!
Cheers,
Wilder
---
If your project is set
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-150676496
@miguelaferreira thanks a lot for your help and advices! As suggested I
post test_nicira_controller.py results:
$ cat
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-150145949
@nvazquez PR looks awesome now. Great work!
I will pull in your PR and run the marvin test we already have against it
to see if that is still good.
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42740183
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -79,6 +79,52 @@ public static boolean
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42740897
--- Diff:
utils/src/main/java/com/cloud/utils/nicira/nvp/plugin/NiciraNvpApiVersion.java
---
@@ -0,0 +1,60 @@
+//
+// Licensed to the
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42740931
--- Diff:
utils/src/main/java/com/cloud/utils/nicira/nvp/plugin/NiciraNvpApiVersion.java
---
@@ -0,0 +1,60 @@
+//
+// Licensed to the
30 matches
Mail list logo
